-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-2050] Implement Passport.js Strategy for MyMLH #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmarkgo
changed the title
Implement Passport.js Strategy for MyMLH
[DEV-2050] Implement Passport.js Strategy for MyMLH
Nov 13, 2024
Tested this with the following example app and it works as expected: https://gist.github.com/jonmarkgo/90dd36ca822fdbd1a259ccbcbcd5ab6a |
- Add core strategy implementation following Facebook patterns - Implement uid, info, and data methods from Ruby implementation - Add comprehensive test suite - Configure package.json with proper metadata The implementation includes: - OAuth2 strategy with MyMLH endpoints - Support for expandable fields - Profile normalization - Comprehensive error handling - Test coverage for core functionality
- Rename Strategy to MLHStrategy throughout the codebase - Export MLHStrategy as both default and named export - Force space separator for MLH scopes - Add proper scope string normalization - Update documentation with scope examples
- Added type: module to package.json - Converted strategy.js to use class syntax and ES module exports - Updated index.js to use ES module imports/exports - Updated test file to use ES module imports - Fixed scope handling and MLHStrategy export issues
- Add core strategy implementation following Facebook patterns - Implement uid, info, and data methods from Ruby implementation - Add comprehensive test suite - Configure package.json with proper metadata The implementation includes: - OAuth2 strategy with MyMLH endpoints - Support for expandable fields - Profile normalization - Comprehensive error handling - Test coverage for core functionality
- Rename Strategy to MLHStrategy throughout the codebase - Export MLHStrategy as both default and named export - Force space separator for MLH scopes - Add proper scope string normalization - Update documentation with scope examples
- Added type: module to package.json - Converted strategy.js to use class syntax and ES module exports - Updated index.js to use ES module imports/exports - Updated test file to use ES module imports - Fixed scope handling and MLHStrategy export issues
- Add explicit profile object construction - Include all required profile fields (displayName, name, emails, phoneNumbers) - Fix failing test for profile normalization
This reverts commit 49f7df2.
- Remove normalized field expectations (displayName, name.familyName) - Add raw field expectations (first_name, last_name) - Keep strategy functionality unchanged
erinosher
force-pushed
the
implementation
branch
from
November 15, 2024 18:52
123e0ec
to
0fbf318
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.