ランダム行動観測ログに音声モダリティを追加 #187
Merged
+84
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
zassou65535
approved these changes
Nov 10, 2024
tests/test_configs.py
Outdated
| @@ -1,4 +1,7 @@ | |||
| """ここではconfigファイル上からオブジェクトを正常にインスタンス化可能かテストします。""" | |||
There was a problem hiding this comment.
Suggested change
| """ここではconfigファイル上からオブジェクトを正常にインスタンス化可能かテストします。""" | |
| """This test checks whether object can be successfully instantiated from config file.""" |
There was a problem hiding this comment.
これは今回の変更に取り込むべきではないね。ということで少し直しておいた。6887cb4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
#186
ホストOSのサウンド系がPulseAudioであることを前提としています。
また、リモートデスクトップでオーディオデバイスが切り替わると音声が取得できなくなってしまうため、データ収集中は注意が必要です。
変更内容
影響範囲
Submit前の確認項目
make runコマンドでローカルでテストしましたか?補足