-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate osm opening hours parsing to external library #900
base: main
Are you sure you want to change the base?
Migrate osm opening hours parsing to external library #900
Conversation
Afaik Android officially still only supports JUnit 4 as a testing library, so I'm fine with that.
Oh no! :D I'd like to publish a release today, so this will probably have to wait for the next version if that's alright? |
Sure, no problem. I'm not in a hurry :) |
closes #860.
I have also added tests with JUnit. Not sure if you'd still want new test implementations to base on a Java-only testing library, but I figured since e.g. tests of
:core:ktx
also use JUnit I'd use that.There are some TODOs left because I somehow underestimated how big of a raging dumpster fire the
opening_hours
spec actually is. ("sunrise to sunset" is a thing!)