Skip to content

Commit

Permalink
Fix MC-256422
Browse files Browse the repository at this point in the history
TODO: Update stats
  • Loading branch information
MMK21Hub committed Dec 11, 2022
1 parent 94ac348 commit e3f091b
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ And here's the list of translation strings that have fixes:
- [World Loaded telemetry event description](https://bugs.mojang.com/browse/MC-257618) (incorrect tense of "pair")
- [Telemetry Data option menu button](https://bugs.mojang.com/browse/MC-258246) (missing ellipsis)
- [`/xp` output messages](https://bugs.mojang.com/browse/MC-203095) (always uses plural nouns)
- [Strings that use the right-quote-mark character](https://bugs.mojang.com/browse/MC-256422) (apostrophes should be used)

### Previously-fixed strings

Expand Down
16 changes: 16 additions & 0 deletions src/fixes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ const autoCapitaliser = new CapitaliseFromTranslationStringsTransformer({
/** If there's a letter right at the end of a string, add a full stop to the end */
const addFullStop = new ReplaceTransformer(/\w$/, "$&.")

/** Replaces right single quotation marks (’) with apostrophes (') */
const standardiseQuoteMarks = new ReplaceTransformer("\u2019", "'")

const fixes: Fix[] = [
new Fix({
bug: "MC-250158",
Expand Down Expand Up @@ -259,6 +262,19 @@ const fixes: Fix[] = [
keyPrefix: "commands.experience",
}
),
...multiFixGroup("MC-256422", standardiseQuoteMarks, [
"gui.chatReport.report_sent_msg",
"gui.banned.description.temporary",
"gui.banned.description.permanent",
]),
...multiFixGroup(
"MC-256422",
standardiseQuoteMarks,
["mco.account.privacyinfo", "telemetry.event.world_load_times.description"],
{
versions: ["22w46a", null],
}
),
]

export default fixes

0 comments on commit e3f091b

Please sign in to comment.