Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfork various fixes and additions #368

Open
wants to merge 58 commits into
base: master
Choose a base branch
from

Conversation

sovetskysoyuz
Copy link

Config and LUA changes:

  • Fixes and enhancements to several MAS props
  • New MAS props using existing models
  • New FMS props and LUA script to allow editing maneuver nodes in IVA
  • New props and LUA script to create KAC alarms in IVA

Changes to the C# code:

  • new circularization function CircularizeAltitudeHypVis() that also work on hyperbolic orbits
  • new functions UpdateOwnDockingPorts() and SetNextDockToReference() to allow changing which docking port is the reference part
  • new function CreateTypeAlarm() to create KAC alarms of any type using input from LUA script
  • new function ClearOneManeuverNode() to clear only the upcoming maneuver node but not others
  • several changes to avoid bugs caused by using a MAS IVA on an uncrewed vessel, e.g. for ProbeControlRoom

Unfortunately I got my git branches mixed up at some point in the past, so many of these changes are entangled, hence bundling all into a single pull request.

I've pulled my code changes and props related to AtmosphereAutopilot out of this branch as I realized that the way I went about it was creating a hard dependency between AvionicsSystems.dll and AtmosphereAutopilot's .dll files, and I'm definitely not familiar enough with C# to try implementing my changes via reflection (which I understand to be the main way of avoiding a hard dependency).

The FMS and KAC props are a little complicated to use; I can write up a wiki page to explain their use if that would help.

All changes are tested on KSP 1.12.5 on both a mod-light install with only MAS and dependencies and a mod-heavy install. I saw no log errors or exceptions related to MAS in my tests. All props were tested for functionality when I originally created them, although some have not been individually tested for functionality on 1.12.

@MOARdV
Copy link
Owner

MOARdV commented Aug 3, 2023

Okay, wow. I will try to look it over this weekend and comment/merge.

@Sheepdog2142
Copy link

Okay, wow. I will try to look it over this weekend and comment/merge.

Can you look into getting the probe control room support in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants