-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unfork various fixes and additions #368
Open
sovetskysoyuz
wants to merge
58
commits into
MOARdV:master
Choose a base branch
from
sovetskysoyuz:unfork
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CreateTypeAlarm
Probe control room compatibility
Add UpdateOwnDockingPorts()
This was referenced Aug 3, 2023
Okay, wow. I will try to look it over this weekend and comment/merge. |
Can you look into getting the probe control room support in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config and LUA changes:
Changes to the C# code:
Unfortunately I got my git branches mixed up at some point in the past, so many of these changes are entangled, hence bundling all into a single pull request.
I've pulled my code changes and props related to AtmosphereAutopilot out of this branch as I realized that the way I went about it was creating a hard dependency between AvionicsSystems.dll and AtmosphereAutopilot's .dll files, and I'm definitely not familiar enough with C# to try implementing my changes via reflection (which I understand to be the main way of avoiding a hard dependency).
The FMS and KAC props are a little complicated to use; I can write up a wiki page to explain their use if that would help.
All changes are tested on KSP 1.12.5 on both a mod-light install with only MAS and dependencies and a mod-heavy install. I saw no log errors or exceptions related to MAS in my tests. All props were tested for functionality when I originally created them, although some have not been individually tested for functionality on 1.12.