Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ArrayReaders): add better error trapping for binary input data #1301

Merged
merged 2 commits into from
Jul 19, 2023
Merged

feat(ArrayReaders): add better error trapping for binary input data #1301

merged 2 commits into from
Jul 19, 2023

Conversation

jdhughes-usgs
Copy link
Contributor

  • modify ArrayReaders to use standard errmsg variable
  • standardize store_error calls in ArrayReaders
  • modify list reader so cellid is only checked if no error condition
  • add binary array input examples to mf6io
  • add binary array input file specifications for each discretization type
  • add binary list input file specifications
  • add description of change to ReleaseNotes

@jdhughes-usgs
feat(ArrayReaders): add better error trapping for binary input data
630d22d 
* modify ArrayReaders to use standard errmsg variable
* standardize store_error calls in ArrayReaders
* modify list reader so cellid is only checked if no error condition
* add binary array input examples to mf6io
* add binary array input file specifications for each discretization type
* add binary list input file specifications
* add description of change to ReleaseNotes
langevin-usgs
langevin-usgs reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Once small tweak for you to consider.

doc/mf6io/framework/array_data.tex Outdated Show resolved Hide resolved
@jdhughes-usgs jdhughes-usgs merged commit b0ae16c into MODFLOW-USGS:develop Jul 19, 2023
20 checks passed
@jdhughes-usgs jdhughes-usgs deleted the binary-error-trap branch July 19, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langevin-usgs langevin-usgs langevin-usgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdhughes-usgs @langevin-usgs