fix(par_nur_has_converged): set mpi_world using get_mpi_world() #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jdhughes-usgs
commented
Jul 19, 2023
jdhughes-usgs
commented
- add test of ex-gwf-bump with and without being split into two models with the flopy model splitter
- add parallel test of of ex-gwf-bump for one and two processors
* add test of ex-gwf-bump with and without being split into two models with the flopy model splitter * add parallel test of of ex-gwf-bump for one and two processors
* add test of ex-gwf-bump with and without being split into two models with the flopy model splitter * add parallel test of of ex-gwf-bump for one and two processors
| hclose = 1e-8 | ||
| hclose_outer = hclose * 10. | ||
| rclose = 1e-3 | ||
| botm = np.loadtxt(pl.Path("data/ex-gwf-bump/bottom.txt")).reshape(shape3d) |
There was a problem hiding this comment.
This may be fine, but I think we have a project_root_path approach for accessing data paths. This is from the prudic example:
import os
import sys
import flopy
import numpy as np
import pytest
from conftest import project_root_path
from framework import TestFramework
from simulation import TestSimulation
ex = ["prudic2004t2"]
data_path = project_root_path / "autotest" / "data"
model_path = data_path / "prudic2004test2"
fname = str(model_path / "lakibd.dat")
lakibd = np.loadtxt(fname, dtype=int)
| chd_spd = [[0, i, 0, H1] for i in range(nrow)] | ||
| chd_spd += [[0, i, ncol - 1, H2] for i in range(nrow)] | ||
| base_heads = flopy.utils.HeadFile( | ||
| pl.Path("data/ex-gwf-bump/results.hds.cmp") |
There was a problem hiding this comment.
same project_root_path issue here
* add test of ex-gwf-bump with and without being split into two models with the flopy model splitter * add parallel test of of ex-gwf-bump for one and two processors
langevin-usgs
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.