-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sfr): add support for CELLIDs with zero values for unconnected reaches #1311
feat(sfr): add support for CELLIDs with zero values for unconnected reaches #1311
Conversation
jdhughes-usgs
commented
Jul 25, 2023
- add deprecation waring for use of NONE for unconnected reaches
- update mf6io with SFR changes
- update ReleaseNotes with SFR changes
- add test of new SFR functionality for unconnected reaches
…eaches * add deprecation waring for use of NONE for unconnected reaches * update mf6io with SFR changes * update ReleaseNotes with SFR changes * add test of new SFR functionality for unconnected reaches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that this worked, because in a preceding call a couple of lines up from the SFR modification there is this:
this%igwfnode(n) = this%dis%noder_from_cellid(cellid, this%inunit, &
this%iout, &
flag_string=.true.)
In looking at noder_from_cellid
and the call to nodeu_from_cellid
it would seem that we should have to specify allowzero
to be .true. Might be worth running that through the debugger to see why/how it works.
* update error message in gwf3dis8 to write a single error message per failure * add sfr failure test to test_gwf_sfr_reorder
* revert test_gwf_sfr_reorder test * make specific test () for sfr packagedata cellid for dis and disv
There is a potential issue with
which should be changed to something like: - 16 1 510 2500. 10 1.81E-03 1077.727 3.0 0.00003 0.03 1 1.0 0
+ 16 1 5 10 2500. 10 1.81E-03 1077.727 3.0 0.00003 0.03 1 1.0 0 are these example files actually tested in any way? |
Good find, @mwtoews. These files are not used in any way other than being written as an example in the mf6io guide. |
…or dis, disv, and disu
* update mf6io SFR RBTH and RHK variable descriptions