Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add PR template, add compiler version to bug report template #1324

Merged
merged 3 commits into from
Aug 8, 2023
Merged

docs: add PR template, add compiler version to bug report template #1324

merged 3 commits into from
Aug 8, 2023

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Aug 4, 2023 •
edited
Loading

as discussed offline

  • add compiler version to suggested info in bug report template (if mf6 built from source)
  • introduce PR template with checklist (should there be any more items?)

langevin-usgs
langevin-usgs reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add "Updated Visual Studio project files (*.vfproj) if new source files added"? Or maybe we should say: "If new source files added, update meson files, makefiles, and Visual Studio project files"

@wpbonelli
Copy link
Contributor Author

Added suggested changes

@wpbonelli wpbonelli merged commit 17a29c4 into MODFLOW-USGS:develop Aug 8, 2023
4 checks passed
@wpbonelli wpbonelli deleted the templates branch August 8, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhughes-usgs jdhughes-usgs jdhughes-usgs left review comments

@langevin-usgs langevin-usgs langevin-usgs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wpbonelli @jdhughes-usgs @langevin-usgs