-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(release): track deprecations in release notes #1329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpbonelli
force-pushed
the
track-deprecations
branch
4 times, most recently
from
August 7, 2023 20:44
00d4062
to
25ee500
Compare
wpbonelli
force-pushed
the
track-deprecations
branch
3 times, most recently
from
August 8, 2023 15:11
b004f90
to
8ba2360
Compare
Inserts a new section Deprecations into release notes, e.g. sample from test run here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. This looks ready to me. Minor edits included in this review.
* add script doc/mf6io/mf6ivar/deprecations.py to scrape DFNs and generate markdown table * run deprecations script in docs.yml CI and upload result file as artifact * add deprecations page to ReadTheDocs * add mk_deprecations.py script to convert markdown deprecations to LaTeX table * include deprecations in release notes * add deprecation policy section to DEVELOPER.md
wpbonelli
force-pushed
the
track-deprecations
branch
from
August 9, 2023 01:35
8ba2360
to
a396359
Compare
thanks @langevin-usgs edits applied. |
langevin-usgs
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/mf6io/mf6ivar/deprecations.py
to scrape DFNs and generate markdown tabledocs.yml
CI and upload result file as artifactmk_deprecations.py
script to convert markdown to LaTeX tablebuild_docs.py
to include deprecations in release notesDEVELOPER.md