Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(par): PETSc Fortran API has changed in v3.22.0 #2030

Merged
merged 17 commits into from
Oct 9, 2024

Conversation

mjr-deltares
Copy link
Contributor

From their release notes https://petsc.org/release/changes/322/:

  • Change the PETSc Fortran API so that non-array values, v, passed to PETSc routines expecting arrays must be cast with [v] in the calling sequence

Checklist of items for pull request

  • Replaced section above with description of pull request
  • Formatted new and modified Fortran source files with fprettify
  • Removed checklist items not relevant to this pull request

@jdhughes-usgs
Copy link
Contributor

@mjr-deltares do you know if this change is backward compatible with older versions of petsc?

@mjr-deltares
Copy link
Contributor Author

mjr-deltares commented Oct 7, 2024

@mjr-deltares do you know if this change is backward compatible with older versions of petsc?

Yes, it should be. (and I will set macOS petsc version back to 3.21 to get this fix to work)

@wpbonelli
Copy link
Contributor

@mjr-deltares after debugging the extended mac build on my fork I took the liberty of pushing to your branch

@mjr-deltares mjr-deltares merged commit e2d9eaa into MODFLOW-USGS:develop Oct 9, 2024
22 checks passed
@mjr-deltares mjr-deltares deleted the fix-petsc-matgetvalue branch October 9, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants