-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(par): PETSc Fortran API has changed in v3.22.0 #2030
Merged
mjr-deltares
merged 17 commits into
MODFLOW-USGS:develop
from
mjr-deltares:fix-petsc-matgetvalue
Oct 9, 2024
Merged
fix(par): PETSc Fortran API has changed in v3.22.0 #2030
mjr-deltares
merged 17 commits into
MODFLOW-USGS:develop
from
mjr-deltares:fix-petsc-matgetvalue
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mjr-deltares do you know if this change is backward compatible with older versions of petsc? |
Yes, it should be. (and I will set macOS petsc version back to 3.21 to get this fix to work) |
- restore local build for petsc on macos
wpbonelli
force-pushed
the
fix-petsc-matgetvalue
branch
from
October 8, 2024 17:58
1156570
to
41097e4
Compare
@mjr-deltares after debugging the extended mac build on my fork I took the liberty of pushing to your branch |
3 tasks
…es/modflow6 into fix-petsc-matgetvalue
- deactivate petsc debug builds on linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From their release notes https://petsc.org/release/changes/322/:
Checklist of items for pull request
fprettify