Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(TspSpc.f90): extend spc utility usage to gwe #2036

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

emorway-usgs
Copy link
Contributor

The SPC utility for SSM works for CONCENTRATION arrays in GWT, but not for TEMPERATURE arrays in GWE. Refactor facilitates use of the SPC utility with GWE's SSM package.

Checklist of items for pull request

  • Replaced section above with description of pull request
  • Added new test or modified an existing test
  • Ran ruff on new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.
  • Formatted new and modified Fortran source files with fprettify
  • Added doxygen comments to new and modified procedures
  • Updated meson files, makefiles, and Visual Studio project files for new source files
  • Updated definition files
  • Updated develop.tex with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • Updated input and output guide

@langevin-usgs
Copy link
Contributor

Looks like this is close. Any thoughts on the failures, @emorway-usgs?

@emorway-usgs
Copy link
Contributor Author

Looks like this is close. Any thoughts on the failures, @emorway-usgs?

Running build_makefiles.py on Windows switches the / to \ in the paths. Being a little out of practice, I forgot to switch 'em back after running the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants