Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sea ice fields (pond area fraction, snow melt rate, and snow-ice formation rate) and updates to existing analyses #1058

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

eclare108213
Copy link
Contributor

@eclare108213 eclare108213 commented Feb 6, 2025

Add new fields: pond area fraction, snow melt rate, snow-ice formation rate.
Add additional seasons and/or change them for all fields except those that already have observational data.
Adjust color bars, especially for differences.
Change tag from 'snow' to 'snow-on-sea-ice'.
Clean up some comments.

Testing:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.eclare/E3SMv3/MPAS_analysis/1985-2014/snow_control-off/sea_ice/index.html

Documentation: https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.eclare/html/users_guide/tasks/climatologyMapSeaIcePondAreaSH.html

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

@eclare108213 eclare108213 requested a review from xylar February 6, 2025 17:55
@eclare108213
Copy link
Contributor Author

I will clean up default.cfg, and I still need to pull the whole thing to my laptop to be able to test the documentation.

@eclare108213 eclare108213 changed the title New sea ice fields (pond area fraction, snow melt rate, and snow-ice formation rate) and updates to existing plots New sea ice fields (pond area fraction, snow melt rate, and snow-ice formation rate) and updates to existing analyses Feb 6, 2025
@eclare108213
Copy link
Contributor Author

Ready for review.

@xylar
Copy link
Collaborator

xylar commented Feb 6, 2025

Thanks @eclare108213! I'll take a careful look tomorrow.

@xylar
Copy link
Collaborator

xylar commented Feb 7, 2025

Sorry, my testing is being delayed by problems with Chrysalis. I don't have access to Compy right now and the queue times on Perlmutter are too slow to be useful, so I'll wait and see if I can test over the weekend.

@xylar xylar self-assigned this Feb 12, 2025
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eclare108213, sorry for the delay in reviewing this. I really appreciate this excellent work. It passes my test suite and the code and documentation looks great, as do the new plots.

It is so exciting to see the sea-ice analysis getting fleshed out. I think we will learn a lot from this. Thank you!

@xylar xylar merged commit 4ad6733 into MPAS-Dev:develop Feb 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants