Floodfill landIceFraction, not landIceMask
#848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
force-pushed
the
fix-land-ice-frac-floodfill
branch
from
4b66796
to
c207ac9
Compare
During the `cull_mesh` step of creating a global ocean mesh, if ice-shelf cavities are present, we need to flood fill to make sure all land ice is connected (no islands of isolated land ice). This merge changes the flood fill to be on all locations where `landIceFraction > 0`, not all locations where `landIceFraction > 0.5`. It then masks all `landIce*` fields to only be nonzero within the flood-filled region. This prevents islands of nonzero `landIceFraction`, `landIcePressure`, `landIceDraft`, etc.
xylar
force-pushed
the
fix-land-ice-frac-floodfill
branch
from
c207ac9
to
1d6ef70
Compare
TestingI tested this in conjunction with #807. Without this fix, there were still regions where Having nonzero |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the
cull_meshstep of creating a global ocean mesh, if ice-shelf cavities are present, we need to flood fill to make sure all land ice is connected (no islands of isolated land ice). This merge changes the flood fill to be on all locations wherelandIceFraction > 0, not all locations wherelandIceFraction > 0.5. It then masks alllandIce*fields to only be nonzero within the flood-filled region. This prevents islands of nonzerolandIceFraction,landIcePressure,landIceDraft, etc.Checklist
Testingin this PR) any testing that was used to verify the changes