-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported python versions #856
Update supported python versions #856
Conversation
97f4f6d
to
8d4dc93
Compare
@xylar as you will see in the changed files, I deleted and added some files in the |
TestingI haven't done any testing yet, as I'm not sure if any of these changes would affect building/running compass. I am happy to run the PR suite if that's desired, but I'll hold off for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! One tiny change.
@@ -217,7 +217,7 @@ Optional flags | |||
Check to make sure expected commands are present | |||
|
|||
``--python`` | |||
Select a particular python version (the default is currently 3.8) | |||
Select a particular python version (the default is currently 3.9) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Select a particular python version (the default is currently 3.9) | |
Select a particular python version (the default is currently 3.12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was very out of date.
@altheaden, these could in theory affect tests but I'm not worried. As long as CI passes, I think we can consider that sufficient testing. |
8d4dc93
to
6aa959c
Compare
@xylar Done! |
Thanks @altheaden! |
Python version 3.8 has now been dropped from conda-forge, and 3.12 has been added. This PR just updates the related checks and files to be consistent with those supported versions.
Checklist
Testing
in this PR) any testing that was used to verify the changes