Add test to make sure features_and_tags.json looks as expected
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexolinhager, I think there are several more things that need to be fixed in |
Closed
alexolinhager
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
@xylar, thanks for making these changes and adding the features and tags test. Makes sense to combine this all into one PR. Looks good to me
|
@alexolinhager, thanks for the review. Can I take this as an implicit approval of #218 and #219? |
|
@xylar, yes, that's fine by me |
This was referenced Dec 21, 2024
For convenience, don't print all the files in the test.
xylar
force-pushed
the
add-check-on-features-and-tags-json
branch
from
5e6d869 to
137aa8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test generates a new
features_and_tags.jsonbased on the contents ofgeometric_data.The contents of
geometric_features/features_and_tags.jsonhave been updated with the correct data produced with:geometric_features.utils.write_feature_names_and_tags().