-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apodized disc function #2748
Merged
Merged
Apodized disc function #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides API equivalent to that already available for generating Apodized Point Spread Functions, but that instead produces a disc of minimal thickness with minimal side lobes.
For first iteration, instead of using ZSH coefficients "1 -1 1" for response function, use the zonal Spherical Harmonic coefficients corresponding to an apodized Disc Function with lmax=4.
Conflicts: core/math/SH.h python/lib/mrtrix3/dwi2response/tournier.py
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
Error introduced in creation of merge 2c6c831.
clang-tidy review says "All clean, LGTM! 👍" |
Given absence of feedback to the contrary, and the fact that there's already supra-threshold differences in other |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little tidbit I thought of as part of a collaboration project.
Replicated the same optimisation process as was used for the refined aPSF RH coefficients in the TODI manuscript; but instead of being 1.0 at [0.0, 0.0, 1.0] and 0.0 everywhere else, it is instead 1.0 at [*, *, 0.0] and 0.0 everywhere else. Produces flat discs that have minimal ringing / zero values.
It is primarily just a new class available in the API. I am however proposing one behavioural change: that this is a better choice compared to a flat disc (with severe ringing) for the first iteration of the
dwi2response tournier
algorithm. Don't know the extent of testing that people may demand to see to accept such a change?