Reslice adapter: allow use with complex numbers #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses an alternative design to f97d3ca / #2768 for supporting complex numbers in the reslice adapter. Specifically in determining the type to use during summation, f97d3ca chooses complex double if the type is not arithmetic, which could hypothetically lead to unexpected behaviour with unexpected template types. This alternative instead utilises the pre-existing is_complex<> SFINAE capability.
|
|
closed in favour of #2785. |
Adapter::Reslice: Alternative resolution of complex summation
|
OK, not closed, but merged #2785 in here as that's how it was set up... |
Lestropie
approved these changes
May 9, 2024
31 tasks
Lestropie
added a commit
that referenced
this pull request
Jan 15, 2025
Resolution of content merged to dev initially omitted from #3061. - #2693 (completely omitted) - #3005 (partial propagation / independent address of some common issues on both branches) - #3001 (completely omitted) - #2908 (completely omitted) - #2955 (completely omitted) - #2600 (completely omitted) - #2962 (completely omitted) - #2935 (completely omitted) - #2923 (completely omitted) - #2910 (completely omitted) - #2638 (completely omitted) - #2698 (completely omitted) - #2721 (completely omitted) - #2794 (completely omitted) - #2768 (completely omitted; required modification to conform to other dev changes) - #2713 (residual compilation errors following adf8fdd, including resolution against changes in #2437 on dev.
Lestropie
added a commit
that referenced
this pull request
Jan 15, 2025
Resolution of content merged to dev initially omitted from #3061. - #2693 (completely omitted) - #3005 (partial propagation / independent address of some common issues on both branches) - #3001 (completely omitted) - #2908 (completely omitted) - #2955 (completely omitted) - #2600 (completely omitted) - #2962 (completely omitted) - #2935 (completely omitted) - #2923 (completely omitted) - #2910 (completely omitted) - #2638 (completely omitted) - #2698 (completely omitted) - #2721 (completely omitted) - #2794 (completely omitted) - #2768 (completely omitted; required modification to conform to other dev changes) - #2713 (residual compilation errors following adf8fdd, including resolution against changes in #2437 on dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix to enable
Adapter::Resliceto work as expected. Required for complex number support inmrpeek(PR: MRtrix3/mrpeek#47).