Skip to content

Commit

Permalink
Merge branch 'main' of https://github.com/MSU-AI/clash-royale-rl into…
Browse files Browse the repository at this point in the history
… MSU-AI-main
  • Loading branch information
lunathanael committed Mar 9, 2024
2 parents 4c388c5 + 78cfbf2 commit bc3815d
Show file tree
Hide file tree
Showing 29 changed files with 202 additions and 121 deletions.
57 changes: 57 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
name: Bug Report
description: Create a bug report to help improve CR-RL
labels: [bug]
body:

# Description
- type: textarea
attributes:
label: Description
description: A clear and concise description of what the issue is.
validations:
required: true

# Step To Reproduce
- type: textarea
attributes:
label: Steps To Reproduce
description: Steps to reproduce the behavior.
placeholder: |
1.
2.
3.
validations:
required: true

# Requirements
- type: textarea
attributes:
label: Requirements
description: describe the expected behavior (eg. Fix crash that occurs when...). If left blank, the issue will likely be closed without discussion.
value: |
- e.g. Fix crash that occurs when...
validations:
required: true

# Python Version
- type: input
id: python_version
attributes:
label: Python Version
description: Which version of Python are you using?
placeholder: "e.g. 3.11"
validations:
required: true

# Log File
- type: textarea
attributes:
label: Log File
description: |
Please upload the log file as an attachment (DO NOT COPY OR PASTE THE CONTENTS INTO THIS FIELD)
placeholder: |
To upload the log, access it from Settings -> About -> Open log location; Or
- Select the `debug.log` file from `%localappdata%\Packages\49306atecsolution.FilesUWP_et10x9a9vyk8t\LocalState`
- Drag and drop the file to upload as an attachment
validations:
required: true
38 changes: 38 additions & 0 deletions .github/ISSUE_TEMPLATE/code_quality_issue.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Code Quality Issue
description: Create a code quality issue to help CR-RL keep a clean codebase
labels: [codebase quality]
body:
- type: textarea
attributes:
label: Description
description: A clear and concise description of what the code quality issue is.
validations:
required: true
- type: textarea
attributes:
label: Concerned code
description: A list of the different files and/or areas of the code concerned by the issue.
validations:
required: true
- type: textarea
attributes:
label: Gains
description: What would fixing this code quality issue bring to the source code?
value: |
- eg. A better readability.
- eg. Uncoupling concepts X and Y.
- eg. Clarifying the responsibility of class C.
validations:
required: true
- type: textarea
attributes:
label: Requirements
description: Describe all the requirements to solve the code quality issue.
value: |
- eg. Using a specific design pattern.
- eg. Separating class I into three new classes I1, I2 and I3.
- eg. Regrouping the duplicated process into a new helper.
- type: textarea
attributes:
label: Comments
description: Additional information, comments or screenshots about the code quality issue.
48 changes: 48 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: Feature Request
description: This project thrives from differentiation from competing apps. Suggest an idea for CR-RL.
labels: [feature request]
body:

# Description
- type: textarea
attributes:
label: What feature or improvement do you think would benefit CR-RL?
description: Please include your use case
validations:
required: true

# Tooltip about Requirements
- type: markdown
attributes:
value: |
---
Please include a list changes required to make this improvement. A good rule of thumb is to start your proposal with no more than 7 high-level requirements.
# Requirements
- type: textarea
attributes:
label: Requirements
description: Describe all the requirements to make your idea happen
value: |
- This proposal will accomplish X
- This proposal will accomplish Y
- This proposal will accomplish Z
validations:
required: true

# Python Version
- type: input
id: python_version
attributes:
label: Python Version
description: Which version of Python are you using?
placeholder: "e.g. 3.11"
validations:
required: true

# Additional Comments
- type: textarea
attributes:
label: Comments
description: Additional information, comments or screenshots about the feature request.
28 changes: 28 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
```md
<!--
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. PR may be deleted if it is not following the template
2. Add a clear title starting with "Feature:" or "Fix:"
3. List any classes/functions used that are not yet defined.
-->

**Resolved / Related Issues**
- [ ] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #issue...

**Validation**
How did you test these changes?
- [ ] Did you run the python notebook and test your changes?
- [ ] Did you implement any design changes to an existing feature?
- [ ] Was this change approved?
- [ ] Are there any dependencies that have yet to be constructed?
Relies on ...
- [ ] Are there any other steps that were used to validate these changes?
1. Unit/Function
2. Discuss with AI side

**Screenshots (optional)**
Add screenshots here.

```
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -159,5 +159,6 @@ cython_debug/
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
#.idea/


# VSCode
.vscode
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# clash-royale-rl
Clash Royale Reinforcement Learning AI
Python: 3.11!
1 change: 0 additions & 1 deletion clash-royale/clash_royale/envs/__init__.py

This file was deleted.

7 changes: 0 additions & 7 deletions clash-royale/setup.py

This file was deleted.

98 changes: 0 additions & 98 deletions clash-royale/testing.ipynb

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from gymnasium.envs.registration import register

register(
id="clash_royale/ClashRoyale",
id="clash-royale",
entry_point="clash_royale.envs:ClashRoyaleEnv",
max_episode_steps=3000,
)
max_episode_steps=14400,
)
1 change: 1 addition & 0 deletions clash_royale/envs/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from clash_royale.envs.clash_royale_env import ClashRoyaleEnv
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
25 changes: 25 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
[build-system]
requires = ["setuptools"]
build-backend = "setuptools.build_meta"

[tool.setuptools.packages]
find = {}

[project]
name = "clash_royale"
version = "0.0.1"
description = "Clash Royale game engine"
readme = "README.md"
dependencies = [
]
authors = [
{ name = "MSU AI Club", email = "[email protected]" },
]
requires-python = ">=3.10"
classifiers = [
"Development Status :: 4 - Beta",
"License :: OSI Approved :: MIT License",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
]
4 changes: 0 additions & 4 deletions reload-env.cmd

This file was deleted.

Binary file removed requirements.txt
Binary file not shown.
8 changes: 0 additions & 8 deletions setup-venv.cmd

This file was deleted.

0 comments on commit bc3815d

Please sign in to comment.