Making spikes have perks for the placer #1135
Conversation
Co-authored-by: LoneWolfHT <[email protected]>
Co-authored-by: LoneWolfHT <[email protected]>
Co-authored-by: LoneWolfHT <[email protected]>
Co-authored-by: LoneWolfHT <[email protected]>
Which test server? |
LV had ran a test server a few days ago testing the spike perk (and another PR + Polls). |
farooqkz
added
Feature ⭐
⚙️ Scoring
Post-approval step ⭐
LoneWolfHT
removed
the
Post-approval step ⭐
I can't reproduce. Correction: I was testing on old code. |
Should the spikes do "full damage" when medics have got immunity? And should the damage be on the behalf of the placer? |
Yeah, if the placer is online, otherwise just deal damage |
|
Spikes work through medic immunity, too. This PR is ready for another review and possible test. I'm using my server to launch a test server. Will post details on Discord. |
| return -7, false | ||
| elseif placer then | ||
| player:punch(placer, 1, { fleshy = 7, spike = 1}) | ||
| return -7, false |
There was a problem hiding this comment.
Doesn't the return value heal any damage dealt?
There was a problem hiding this comment.
In fact, I don't think this code is reachable unless they aren't damaged by a spike
There was a problem hiding this comment.
In fact, I don't think this code is reachable unless they aren't damaged by a spike
how so? Are you talking about L121 or L123-124?
There was a problem hiding this comment.
110: if team and reason.node == string.format("ctf_map:spike_%s", team) then
LV/LW said it works on his machine so I didn't test further.