Fix treasure chest chat spam #1327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix spammed messages sent to player when adding an item into treasure chest using Shift+ Item
|
Hello. Thanks for your interest in contributing to CTF. Please update the PR title with a better more descriptive name. Also I am in favor of removing this message from chat and sending as HUD event message, instead. @LoneWolfHT Opinion(s)? |
|
hud messages would be hidden by the formspec, the chat gives you a better chance of seeing what went wrong. |
LoneWolfHT
requested changes
Jul 25, 2024
| if current_time - last_time_warned > 0.01 then | ||
| minetest.chat_send_player(player:get_player_name(), | ||
| "You're not allowed to put things in treasure chests!") | ||
| meta:set_int("last_chest_time_warned", current_time) |
There was a problem hiding this comment.
The timer doesn't need to be chest-specific, so for speed's sake instead of storing the current time in meta I would store it in a local table indexed by playername, when a player leaves their entry is removed.
|
Are you still interested in finishing this PR or do you want someone to take it over? |
|
Got answer via Discord, this PR is up for adoption |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix spammed messages sent to player when adding an item into treasure chest using Shift+ Item