[MISSION] Garder le formulaire des infractions ouverts #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claire2212
reviewed
Jun 21, 2024
| @@ -31,7 +31,12 @@ export function useSyncFormValuesWithRedux(isAutoSaveEnabled: boolean) { | |||
| const isFormDirty = isMissionFormDirty() | |||
|
|
|||
| dispatch( | |||
| missionFormsActions.setMission({ activeActionId, engagedControlUnit, isFormDirty, missionForm: newValues }) | |||
| missionFormsActions.setMission({ | |||
There was a problem hiding this comment.
même remarque que dans ma précédente PR, mais pourquoi récupérer un objet (ligne 22) du state pour ensuite le ré-injecter tel quel ?
There was a problem hiding this comment.
Car l'action redux qui met à jour le formulaire automatiquement (synchro des missions) ne reprenait pas toutes les props et se déclenche régulièrement. C'est réglé !
|
@maximeperrault il y a un souci quand on clique sur un signalement rattaché, le formulaire ne s'affiche pas et la card de la timeline ne se met pas avec la bordure bleue |
|
@claire2212 Merci pour ta vigilance, j'ai rien qui pétait dans les tests. Tout ça pour une histoire de cast d'ID... |
claire2212
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues