[Moyens et unités] Finalisation de la fiche unité #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivangabriele
force-pushed
the
ivan/finalize-control-unit-map-dialog
branch
from
98acc2c
to
3086ea6
Compare
ivangabriele
commented
Oct 9, 2023
frontend/src/features/ControlUnit/components/ControlUnitListDialog/slice.ts
Outdated
Show resolved
Hide resolved
claire2212
approved these changes
Oct 9, 2023
| export enum SeaFrontEnum { | ||
| // TODO Why is it not in ALL MAJ? Does the DB has a mix of both cases (`Guadeloupe`, `SOUTH_INDIAN_OCEAN`)? |
There was a problem hiding this comment.
oui, il y a un mix de majuscule et minuscule en DB
frontend/src/features/MainWindow/useCases/handleModalConfirmation.ts
Outdated
Show resolved
Hide resolved
frontend/src/features/ControlUnit/usesCases/deleteControlUnitResource.ts
Outdated
Show resolved
Hide resolved
frontend/src/features/ControlUnit/usesCases/deleteControlUnit.ts
Outdated
Show resolved
Hide resolved
ivangabriele
force-pushed
the
ivan/finalize-control-unit-map-dialog
branch
from
8c54450
to
7ba50b8
Compare
ivangabriele
commented
Oct 11, 2023
There was a problem hiding this comment.
Après discussion avec Claire, je mets une note de review ici : je vais abandonner le système utilisant Redux pour afficher les dialog/modal communes pour utiliser plutôt un système "in-component" çad rendu là où elles sont appelées.
Mais je le ferai sur ma prochaine PR.
ivangabriele
force-pushed
the
ivan/finalize-control-unit-map-dialog
branch
from
bbda84f
to
8402b29
Compare
thoomasbro
changed the title
ivangabriele
force-pushed
the
ivan/finalize-control-unit-map-dialog
branch
from
d8f98cc
to
c394500
Compare
ivangabriele
force-pushed
the
ivan/finalize-control-unit-map-dialog
branch
from
31aebc0
to
e4d06e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs & Issues