Thomas/backend env actions attached to reportings #887

thoomasbro · 2023-10-17T16:14:44Z

No description provided.

louptheron · 2023-10-18T13:33:15Z

...src/main/kotlin/fr/gouv/cacem/monitorenv/domain/entities/mission/envAction/ActionTypeEnum.kt

@@ -1,4 +1,4 @@
-package fr.gouv.cacem.monitorenv.domain.entities.mission
+package fr.gouv.cacem.monitorenv.domain.entities.mission.envAction


Suggested change

package fr.gouv.cacem.monitorenv.domain.entities.mission.envAction

package fr.gouv.cacem.monitorenv.domain.entities.mission.action

J'avoue que depuis le début je ne suis pas super fan de ce nommage, une action dans ce repo est pas définition une action Env, car il n'y en a aucune autre.

Il me semble qu'au début on n'était pas sûrs de ce qu'allait stocker la base monitorEnv, et j'imaginais qu'il pouvait y avoir d'autres types d'actions. Ok pour renommer en envAction en action. Est ce qu'on renomme aussi la table en db ? (je dirais plutot non)

louptheron · 2023-10-18T13:34:38Z

.../cacem/monitorenv/domain/entities/mission/envAction/envActionControl/ActionTargetTypeEnum.kt

@@ -0,0 +1,7 @@
+package fr.gouv.cacem.monitorenv.domain.entities.mission.envAction.envActionControl


Ici, le envActionControl fait déjà partie du package envAction donc ça me semble une répétition de naming de package

louptheron · 2023-10-18T13:39:21Z

.../src/main/kotlin/fr/gouv/cacem/monitorenv/domain/use_cases/missions/CreateOrUpdateMission.kt

-        reportingRepository.attachReportingsToMission(
-            attachedReportingIds ?: listOf(),
-            savedMission.mission.id,
-        )

        return missionRepository.findById(savedMission.mission.id)


Pourquoi ce findBy avec que save renvoie la mission ?

c'est une confusion de ma part entre le useCase et la couche JPA.

louptheron · 2023-10-18T13:42:12Z

...ouv/cacem/monitorenv/domain/use_cases/missions/CreateOrUpdateMissionWithAttachedReporting.kt

+    private val departmentRepository: IDepartmentAreaRepository,
+    private val facadeRepository: IFacadeAreasRepository,
+    private val missionRepository: IMissionRepository,
+    private val reportingRepository: IReportingRepository,


Suggested change

private val reportingRepository: IReportingRepository,

private val reportingRepository: IReportingRepository,

private val createOrUpdateMission: CreateOrUpdateMission,

Je pense que CreateOrUpdateMissionWithAttachedReporting devrait utiliser le use-case CreateOrUpdateMission en dépendance injectée, pour éviter de répéter du code et pour faciliter le refacto par la suite.
Ce use-case deviendra plus simple, avec seulement les l.96 à l.106.

louptheron · 2023-10-18T13:48:20Z

...kotlin/fr/gouv/cacem/monitorenv/infrastructure/api/endpoints/bff/MissionsControllerITests.kt

@@ -290,11 +298,14 @@ class MissionsControllerITests {
                isGeometryComputedFromControls = false,
            ),
        )
-        val envAction = EnvActionControlEntity(
+        val envAction = MissionEnvActionDataInput(


Dans ce test j'aurais bien testé le when de MissionEnvActionDataInput (avec un Mockito.verify() ici ou alors un test unitaire de MissionEnvActionDataInput), c'est fréquent d'oublier des propriétés dans ce type de mapper

…porting in form when user attach a reporting to a control

…table

…ith mission

…ission

…and detached mission date in back

…is linked to a reporting

…porting

…porting in form when user attach a reporting to a control

…and detached mission date in back

thoomasbro · 2023-11-03T08:50:40Z

Cherrypicked in claire/attach-reporting-to-mission

thoomasbro requested a review from claire2212 October 17, 2023 16:14

claire2212 requested a review from louptheron October 18, 2023 07:39

louptheron reviewed Oct 18, 2023

View reviewed changes

claire2212 added 24 commits October 20, 2023 10:33

[Reporting] select mission to attach on map

ac83266

[Mission] display reportings in mission form

ef683e4

[Reporting] save and create a new mission with attached reporting

94d7638

[Mission] clean Timeline in mission form and create hook to update re…

9c4d068

…porting in form when user attach a reporting to a control

[Reporting] attach a mission to a reporting from map

a4ce89f

[Reporting] display attached mission and action status in reportings …

9d5acd2

…table

[Reporting] clean layers and add reporting selection on map to link w…

9464346

…ith mission

[Mission] can attach multiple reportings from map

de7621b

[Reporting] add LinkMission tag and

14fd990

[Map] fix display or not layer during interaction on map

abd253c

[Map] clean reportings on map

fa7e4ab

[Tech] clean and refacto

b1fc89a

[Reporting] update reporting on map when archived and attached to a m…

5cdc43d

…ission

[Tech] clean after rebase

0c4d473

[Tech] clean after rebase

7056d30

[Tech] delete useless code

f464aee

[Reporting] clean cache for reporting and mission apis, add attached …

9cf474d

…and detached mission date in back

[Reporting] some bug fixes

71dd862

[Mission] fix update attached reportings query

cffdf11

[Reporting] check detachedFromMissionAtUtc prop to know if a mission …

8addc9d

…is linked to a reporting

[Mission] can detach the only reporting attached to mission

78d8bc1

[Mission] display detached reportings in mission form

e3ecd3f

[Test] add test e2e to attach and detach a mission from a reporting

ae1d980

[Reporting] fix bug with attached mission when add or edit another re…

f147a0a

…porting

claire2212 force-pushed the claire/attach-reporting-to-mission branch from 580ed2f to f147a0a Compare October 20, 2023 08:42

claire2212 added 2 commits October 20, 2023 10:57

[Mission] display reportings in mission form

12c99e7

[Reporting] save and create a new mission with attached reporting

f16dcfe

claire2212 and others added 12 commits October 20, 2023 11:05

[Mission] clean Timeline in mission form and create hook to update re…

cafa7ed

…porting in form when user attach a reporting to a control

[Reporting] attach a mission to a reporting from map

f7bde2a

[Tech] clean after rebase

6449c7a

[Reporting] clean cache for reporting and mission apis, add attached …

7df41ed

…and detached mission date in back

[Reporting] some bug fixes

9e4bcd8

[Mission] can detach the only reporting attached to mission

33cae42

envActionsAttachedToReportings

dbf0912

envActionsAttachedToReportings

8169ec2

attachEnvActionsToReportings

2153184

refacto envActionDataOutput

c9ee998

remove duplicate code

7785ce8

Refactor CreateOrUpdateMissionWithAttachedReporting

e352bbc

claire2212 force-pushed the thomas/backend-envActionsAttachedToReportings branch from 97e6e7d to e352bbc Compare October 20, 2023 09:39

[Tech] fix after rebase

414fc52

claire2212 force-pushed the thomas/backend-envActionsAttachedToReportings branch from ee5f2b2 to 414fc52 Compare October 20, 2023 12:02

[Test] add backend unit test

475015b

claire2212 force-pushed the claire/attach-reporting-to-mission branch 2 times, most recently from 4695f31 to c127f7a Compare October 30, 2023 07:48

thoomasbro force-pushed the claire/attach-reporting-to-mission branch 3 times, most recently from b1593ea to 7e314a8 Compare November 2, 2023 22:19

thoomasbro closed this Nov 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Thomas/backend env actions attached to reportings #887

Thomas/backend env actions attached to reportings #887

thoomasbro commented Oct 17, 2023

louptheron Oct 18, 2023

thoomasbro Oct 20, 2023

louptheron Oct 18, 2023

louptheron Oct 18, 2023

thoomasbro Oct 20, 2023

louptheron Oct 18, 2023

louptheron Oct 18, 2023

thoomasbro commented Nov 3, 2023

		@@ -1,4 +1,4 @@
		package fr.gouv.cacem.monitorenv.domain.entities.mission
		package fr.gouv.cacem.monitorenv.domain.entities.mission.envAction

		@@ -0,0 +1,7 @@
		package fr.gouv.cacem.monitorenv.domain.entities.mission.envAction.envActionControl

	private val reportingRepository: IReportingRepository,
	private val reportingRepository: IReportingRepository,
	private val createOrUpdateMission: CreateOrUpdateMission,

Thomas/backend env actions attached to reportings #887

Thomas/backend env actions attached to reportings #887

Conversation

thoomasbro commented Oct 17, 2023

louptheron Oct 18, 2023

Choose a reason for hiding this comment

thoomasbro Oct 20, 2023

Choose a reason for hiding this comment

louptheron Oct 18, 2023

Choose a reason for hiding this comment

louptheron Oct 18, 2023

Choose a reason for hiding this comment

thoomasbro Oct 20, 2023

Choose a reason for hiding this comment

louptheron Oct 18, 2023

Choose a reason for hiding this comment

louptheron Oct 18, 2023

Choose a reason for hiding this comment

thoomasbro commented Nov 3, 2023