enable password validation #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the settings are taken from the default Django settings.py
|
Thanks @Bomme! That unfortunately means I won't be able to use 12345678 as my test password anymore :S |
ffont
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces password validation for user registration and password change.
Up to now, there was no password validation done and consequently no password requirements enforced.
The settings are taken from the default Django
settings.py.If I'm not mistaken there should be no effect on currently stored passwords. Only, new (and changed) passwords will need to fulfill the requirements.
Conveniently, the default password change form will inform the user about the password requirements (see below).
Before:
After:
Deployment steps:
None