Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move contents of _LICENSE dir to special files for auto discoverability #1742

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

Bomme
Copy link
Contributor

@Bomme Bomme commented Dec 30, 2023

Issue(s)
#1683

Description
As suggested by @alastair I moved the license statement to the top level directory so that it gets read by GitHub. Moreover, I created an ACKNOWLEDGMENTS file containing the licenses of the python dependencies as generated by pip-licenses.

I followed this recommendation:

ACKNOWLEDGMENTS File: ACKNOWLEDGMENTS or ACKNOWLEDGMENTS.txt or ACKNOWLEDGMENTS.md etc. is a file that describes related work, such as other projects that are dependencies, or libraries, or modules, or have their own copyrights or licenses that you want to include in your project.

Deployment steps:
None

Also, the dependency licenses are updated using pip licenses
@Bomme Bomme requested review from alastair and ffont December 30, 2023 16:18
@ffont ffont merged commit d098e1b into master Jan 11, 2024
1 check passed
@ffont ffont deleted the licenses_discoverability branch January 11, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants