Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR schema: convert license to a docValues field for faster faceting #1760

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

Bomme
Copy link
Contributor

@Bomme Bomme commented May 2, 2024

Description
Change the type of license to string similar to other fields to mark docValues as true. This should help speed up faceting of search results.

The fieldType definition looks like this:
<fieldType name=“string” class=“solr.StrField” sortMissingLast=“true” docValues=“true”/>

Deployment steps:
Re-indexing required!

@Bomme Bomme requested review from alastair and ffont May 2, 2024 18:09
@ffont
Copy link
Member

ffont commented May 7, 2024

This is nice, thanks @Bomme !
Did you check if there are other fields used in faceting that might need similar treatment?

Also in beta search features we do faceting with dynamic fields as well, and I wonder how this would be affecting faceting performance. We'll have to investigate these issues before making some of these extra facets public.

Copy link
Member

@ffont ffont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Bomme !
I added an extra change to make the "free cultural works" filter work with the now case sensitive license field. Now this should be ready to merge when Solr is reindexed :)

@ffont ffont merged commit 4b5b709 into master Oct 17, 2024
1 check failed
@ffont ffont deleted the docvalues_license branch October 17, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants