Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support references to config objects in custom plugin configurations #405

Merged
merged 4 commits into from
May 6, 2024

Conversation

sven-n
Copy link
Member

@sven-n sven-n commented Mar 20, 2024

With #403 we noticed that it wasn't possible to add references to configration objects, such as ItemDefinition to custom plugin configurations. So, I added some infrastructure to support that.
It's working, but I don't like one thing about it yet: In the DI setup, we call some async code and wait for that to finish. So I keep this PR as Draft until I found a solution.
For a test I implemented a simple plugin config to fix #400.

@sven-n sven-n marked this pull request as ready for review May 6, 2024 18:26
@sven-n sven-n merged commit de77e18 into master May 6, 2024
1 of 3 checks passed
@sven-n sven-n deleted the custom-plugin-config-ext branch May 6, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Fenrir cannot be repaired with a Jewel of Bless
1 participant