-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests back to pipeline & improve VSCode integration #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds on the Ruby Test Explorer VSCode extension. See my comment here: connorshea/vscode-ruby-test-adapter#30 (comment)
Splines
added
the
CI/CD
Continuous Integration / Continuous Delivery (aka pipeline stuff)
label
Jan 7, 2024
Splines
changed the title
Add tests back to pipeline & improve VSCode integration
Add unit tests back to pipeline & improve VSCode integration
Jan 7, 2024
buildx is used for faster builds we also set up ghcr to use docker layer caching for hopefully even faster build times
Splines
force-pushed
the
pipeline/tests
branch
8 times, most recently
from
January 10, 2024 15:55
54a1fd9
to
9feac40
Compare
Splines
force-pushed
the
pipeline/tests
branch
from
January 10, 2024 15:57
9feac40
to
63544f8
Compare
Splines
added
the
ide
Related to integrated developer environments, e.g. VSCode etc.
label
Jan 10, 2024
Other layers will get cached anyways as they are external images.
This may be a fix for the issue `Can't modify frozen hash` we get in the pipeline during the unit tests.
Initial setup of the database cleaner was done here: b901205 Maybe related to fix database cleaner issues: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #581 +/- ##
======================================
Coverage ? 66.62%
======================================
Files ? 309
Lines ? 9388
Branches ? 0
======================================
Hits ? 6255
Misses ? 3133
Partials ? 0 ☔ View full report in Codecov by Sentry. |
fosterfarrell9
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #571 and it fixes #507.
Ruby Test Explorer extension works now in VSCode. Also see my comment here.
Note
For the Ruby Test Explorer extension to work, you must have a recent python version installed
Currently, the CI/CD test runs take ~4min 30s (with some things already cached). Without any caches it even takes up to ~7min. This is too long and we should try to reduce the time spent in the initial docker build phase. However, this would probably mean restructuring what is done in the dockerfiles, which should probably be something for another PR.
Future Todos
.wasm
file from thepdfcomprezzor
to the project root etc.Further notes
Currently, this PR also incorporates changes from Upgrade Node.js dev dependencies & fix ESLint config #636. This is why we should merge Upgrade Node.js dev dependencies & fix ESLint config #636 beforehand ⚠ Note that you must runyarn install
locally to have up-to-date dependencies.These are due to sunspot/sunspot#1039 and we have to wait for the fix (sunspot/sunspot#1038) to be merged.
Output
pane ->Ruby Test Explorer Log
. An alternative is to just build the image as usual in the terminal yourself, e.g.docker build mampf
inside the./docker/test
folder. For more troubleshooting tips, see the wiki.Additional for reviewers