Fix GUI statement links

[eloiferrer]

MaRDI Pull Request

Changes:

• This is an attempt to fix Statements cannot be added locally through the GUI #386 by changing the paths.
• This also fixes a couple of mistakes regarding the env variables in docker-compose.yml

Instructions for PR review:

• Conceptual Review (Logic etc...)
• Code Review (Review your implementation)
• Checkout (Test changes locally)

Checklist for this PR:

• Reviewers and Assignee specified.
• All related issues are linked.

[physikerwelt]

I think it would be better to overwrite the values for local development. If we merged this as it is it would break the staging software links.

[eloiferrer]

Isn't there some variable that saves the portal.mardi4nfdi.de url and that can be accessed from Wikibase.php? It somehow doesn't look right to have this hard-coded urls in there.

[physikerwelt]

I think this is the variable to be set. Maybe there is something like concept URI from the linkedwiki extension, but I don't know.

[physikerwelt]

I would have used getenv instead of _ENV but it does not really matter. Decide on your own feelings https://stackoverflow.com/a/8798318

[eloiferrer]

Ok. Since we will have now a PORTAL_HOST variable with portal.mardi4nfdi.de as value, would it be ok if I change all the instances of portal.mardi4nfdi.${TLD} in docker-compose.yml to just ${PORTAL_HOST}? e.g. quickstatements.portal.mardi4nfdi.${TLD} to quickstatements.${PORTAL_HOST} and so on.

[physikerwelt]

I think so.

[eloiferrer]

@physikerwelt I changed the logic again, so maybe just take a final look, before I merge it.

[physikerwelt]

I think it is ok, however, I find maintaining the localhost:port alternative creates a huge overhead and makes the dev environment different from production so that some parts need to developed twice. I would thus recommend to remove the localhost:port alternative and use a pseudo domain that points to localhost instead.

[eloiferrer]

I don't see if that is really the case here. This implementation does not change the current workflow we have. We are already changing the WIKIBASE_HOST and PORT for development

portal-compose/README.md

Line 21 in f5ef817

WIKIBASE_HOST=localhost

. So no changes in the current dev environment are needed.

[physikerwelt]

I don't see if that is really the case here. This implementation does not change the current workflow we have.

Yes, I fully agree. So it is as bad as it was before:-)

We are already changing the WIKIBASE_HOST and PORT for development

At least when trying to get quick statements to run, I found the combination of hosts and ports quite confusing.

portal-compose/docker-compose.yml

Lines 321 to 328 in f5ef817

	- traefik.http.routers.service-quickstatements.rule=Host(`quickstatements.portal.mardi4nfdi.${TLD}`)
	- traefik.http.routers.service-quickstatements.entrypoints=websecure
	- traefik.http.routers.service-quickstatements.tls.certResolver=le
	environment:
	- QUICKSTATEMENTS_HOST=https://quickstatements.portal.mardi4nfdi.${TLD}
	- WIKIBASE_SCHEME_AND_HOST=http://wikibase-docker.svc
	- QS_PUBLIC_SCHEME_HOST_AND_PORT=https://quickstatements.portal.mardi4nfdi.${TLD}
	- WB_PUBLIC_SCHEME_HOST_AND_PORT=https://portal.mardi4nfdi.${TLD}

For example, https://quickstatements.portal.mardi4nfdi.${TLD} points to nowhere in local dev.

This PR, in particular,

https://github.com/MaRDI4NFDI/portal-compose/pull/387/files#diff-1593a24ff7c433502c819e45226b229d3c70082067e354b7208944164926a3f0R9-R13

adds further technical debts to handle both cases, dev, and prod. Instead, I suggest it would be easier to guide developers to install a custom DNS like described here https://github.com/bnfinet/docker-dns

[physikerwelt]

@eloiferrer what do you think?

I checked https://staging.swmath.org/wiki/Mathoid and saw that the link to the MaRDI portal item is currently missing, but the other direction from https://portal.mardi4nfdi.de/wiki/Item:Q38023 works. So that needs to be fixed anyhow. So I think it would be a good time to merge this now.