Added bold on current page #175
Conversation
|
@Tamir198 is attempting to deploy a commit to a Personal Account owned by @Maakaf on Vercel. @Maakaf first needs to authorize it. |
| <li className="cursor-pointer body-roman"> | ||
| <Link href={LINKS.PROJECTS} className='transition duration-300 group'>הפרויקטים | ||
| <span className="block max-w-0 group-hover:max-w-full transition-all duration-500 h-0.5 bg-sky-600"/> | ||
| <li className={`cursor-pointer body-roman ${currentPage === 'projects' ? 'font-bold' : ''}`}> |
There was a problem hiding this comment.
Maybe using an array for future use if there will be changes in the nav. All the styles here is duplicated
There was a problem hiding this comment.
Maybe using an array for future use if there will be changes in the nav. All the styles here is duplicated
makes sense....want me to assign you this?
There was a problem hiding this comment.
@Tamir198 Is already on it no?
There was a problem hiding this comment.
He did start but was not assigned its an oversight on my end.
he is now :D
thanks for looking into this!
There was a problem hiding this comment.
Do you mean an array that will contain the strings? something else?
Generally, we have a lot of styles duplicated all over the project.
In my opinion, It will be better to use layer to create custom classes for generic purposes (for example, card, navItem etc...) together with generic components.
If the same style repeats itself it can be a good indication that this part can be extracted into a custom component.
I think that think is a project level thing, related to the project architecture.
There was a problem hiding this comment.
I was thinking about array of the items in the header and then iterate over it inside the header with the same style
Fixed #173
Added missing bold on the current page libnk :