Change direction he #263
Merged
Change direction he #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tamir198
suggested changes
May 6, 2024
| className={`fixed inset-0 z-50 flex items-center justify-between px-10 bg-lightBg dark:bg-darkBg max-h-24 ${ | ||
| locale === 'he' && 'flex-row-reverse' | ||
| }`} | ||
| > |
There was a problem hiding this comment.
We have a useLocalStorage.ts for that please use it.
There was a problem hiding this comment.
can u help me understand 2 things
- I can't use useLocalStorage in server component Heders and layout
- what is the point of using local storage in the first place because
localeis updated fine (tnx to middleware) at my tests
can u enlight me what I am missing here
There was a problem hiding this comment.
Sorry my mistake here, i ment to say that we have a hook for language ditection (no idea why I was talking about localstorage)
Tamir198
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first add FilteringProjectsBug brach