fix sidebar English language #286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Darkmift
reviewed
May 19, 2024
components/Header/Sidebar.tsx
Outdated
| const { theme } = useTheme(); | ||
| const t = useTranslations('Components.sideBar'); | ||
| const navigationItems: NavigationItems[] = [ |
There was a problem hiding this comment.
in this scope this array will be re declared on every render
There was a problem hiding this comment.
I know, but how can I use the "useTranslations" hook outside this scope?
Darkmift
reviewed
May 19, 2024
| `fixed inset-y-0 z-50 bg-lightBg dark:bg-darkBg border-l | ||
| border-l-blue-400 w-[75%] shadow-lg transform transition-transform | ||
| ease-in-out duration-300`, | ||
| { |
There was a problem hiding this comment.
can we not use dir here?
There was a problem hiding this comment.
It didn't worked so well using dir
Darkmift
requested changes
May 19, 2024
|
@noams24 please resolve conflicts |
|
@noams24 please update |
|
I still couldn't figured how to fix this error: Maybe @Tamir198 knows how solve it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #271