Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpu readout #278

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Add gpu readout #278

merged 6 commits into from
Mar 27, 2023

Conversation

Rolv-Apneseth
Copy link
Contributor

In relation to #107.

Add the ability to display connected GPUs with the readout information provided by libmacchina v6.4.0, added in this PR. This functionality is currently only implemented for Linux.

@Rolv-Apneseth
Copy link
Contributor Author

Not sure what's causing that Android error:

clang90: error: linker command failed with exit code 1 (use -v to see invocation)

What's the best way to go about trying to diagnose / fix this?

@grtcdr
Copy link
Member

grtcdr commented Mar 26, 2023

Huh, I thought I fixed this in Macchina-CLI/libmacchina@d5077cd as @Gobidev suggested in Macchina-CLI/libmacchina#142.

@Gobidev
Copy link
Contributor

Gobidev commented Mar 26, 2023

@grtcdr I also got very confused there for a second😅
We only fixed this in libmacchina, macchina has the same problem. I made a PR: #280

@Gobidev
Copy link
Contributor

Gobidev commented Mar 26, 2023

@Rolv-Apneseth rebasing with upstream will fix the failing Android build

@Rolv-Apneseth
Copy link
Contributor Author

@Rolv-Apneseth rebasing with upstream will fix the failing Android build

Nice, thank you

src/data/mod.rs Outdated Show resolved Hide resolved
@grtcdr
Copy link
Member

grtcdr commented Mar 27, 2023

Thanks a lot for working on this, Rolv.

@Rolv-Apneseth
Copy link
Contributor Author

No worries, thanks for this awesome tool

@grtcdr grtcdr merged commit e01f581 into Macchina-CLI:main Mar 27, 2023
@Rolv-Apneseth Rolv-Apneseth deleted the add_gpu_readout branch March 28, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants