feat: 🎸 new component inputSearch, now you can use the x to clean input value #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in achievement page was an input without type search, the update make a new type of input and improve a11y
|
Hey how's it going ? @MadeBaruna I now you need to take your time, but when you have a free time, could you see this significant improvement ? 🥺 |
timmychan97
reviewed
Jul 5, 2023
src/components/Input.svelte
Outdated
| input[type="search"]::-webkit-search-results-decoration { | ||
| display: none; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Please add an empty line to the bottom of the file.
BREAKING CHANGE: 🧨 no
empty line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see, I use a lot this page
But was annoying me, the fact that the input isn't a type search, so I made this 🥲
now you can use esc to clean the input or if you in a mobile device you can click on the X button ❤️
I really wanna this feature on the site PLEASE MERGE ME 😩 (will help me alot)