Allow to close FsSet instance while locked

Mafalda-SFU · Nov 19, 2023 · 8992c26 · 8992c26
1 parent 6da8151
commit 8992c26
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/__tests__/waiting.js b/__tests__/waiting.js
@@ -70,3 +70,15 @@ test('lifecycle', async function()
 
   expect(result).toBe(false)
 })
+
+test('close while locked', async function()
+{
+  const set = new FsSetWaiting(temporaryFile())
+
+  const promise = set.lock(function()
+  {
+    set.close()
+  })
+
+  await expect(promise).resolves.toBeUndefined()
+})
diff --git a/waiting.js b/waiting.js
@@ -39,7 +39,8 @@ export default class FsSetWaiting extends FsSetAbstract
     }
     finally
     {
-      if(!--this.#locks) await promisedFcntl(this._fd, F_SETLKW, F_UNLCK)
+      if(!(--this.#locks || this.closed))
+        await promisedFcntl(this._fd, F_SETLKW, F_UNLCK)
     }
   }