Skip to content

Commit

Permalink
Merge tag '3.12.9' into v3
Browse files Browse the repository at this point in the history
3.12.9

# Conflicts:
#	package-lock.json
#	package.json
  • Loading branch information
github-actions committed Aug 10, 2023
2 parents 778ffae + c0a6988 commit a1b477e
Show file tree
Hide file tree
Showing 20 changed files with 1,341 additions and 898 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

### 3.12.9

* Fix RTCP SDES ([PR #1139](https://github.com/versatica/mediasoup/pull/1139)).


### 3.12.8

* Export `workerBin` absolute path ([PR #1123](https://github.com/versatica/mediasoup/pull/1123)).
Expand Down
12 changes: 6 additions & 6 deletions node/src/Router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ type PipeTransportPair =
};

export type RouterEvents =
{
{
workerclose: [];
// Private events.
'@close': [];
Expand Down Expand Up @@ -465,14 +465,14 @@ export class Router<RouterAppData extends AppData = AppData>
this.#dataProducers.delete(dataProducer.id)
));

// Emit observer event.
this.#observer.safeEmit('newtransport', transport);

if (webRtcServer)
{
webRtcServer.handleWebRtcTransport(transport);
}

// Emit observer event.
this.#observer.safeEmit('newtransport', transport);

return transport;
}

Expand Down Expand Up @@ -1080,7 +1080,7 @@ export class Router<RouterAppData extends AppData = AppData>
{
throw new TypeError('if given, appData must be an object');
}

const reqData =
{
rtpObserverId : uuidv4(),
Expand All @@ -1103,7 +1103,7 @@ export class Router<RouterAppData extends AppData = AppData>
this.#producers.get(producerId)
)
});

this.#rtpObservers.set(activeSpeakerObserver.id, activeSpeakerObserver);
activeSpeakerObserver.on('@close', () =>
{
Expand Down
2 changes: 1 addition & 1 deletion node/src/tests/test-Consumer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ test('transport.consume() with enableRtx succeeds', async () =>
audioConsumer2.close();
}, 2000);

test('transport.consume() can be created with user provided mid', async () =>
test('transport.consume() can be created with user provided mid', async () =>
{
const audioConsumer1 = await transport2.consume(
{
Expand Down
Loading

0 comments on commit a1b477e

Please sign in to comment.