Merge tag '3.12.16' into v3

3.12.16

# Conflicts:
#	package-lock.json
#	package.json

CHANGELOG.md

@@ -1,6 +1,11 @@
 # Changelog
 
 
+### 3.12.16
+
+* Fix `IceServer` crash when client uses ICE renomination ([PR #1182](https://github.com/versatica/mediasoup/pull/1182)).
+
+
 ### 3.12.15
 
 * Fix NPM "postinstall" task in Windows ([PR #1187](https://github.com/versatica/mediasoup/pull/1187)).

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mafalda-sfu/mediasoup",
-  "version": "3.12.15",
+  "version": "3.12.16",
   "description": "Cutting Edge WebRTC Video Conferencing",
   "contributors": [
     "Iñaki Baz Castillo <[email protected]> (https://inakibaz.me)",
@@ -104,8 +104,8 @@
     "@types/uuid": "^9.0.6",
     "@typescript-eslint/eslint-plugin": "^6.8.0",
     "@typescript-eslint/parser": "^6.8.0",
-    "eslint": "^8.51.0",
-    "eslint-plugin-jest": "^27.4.2",
+    "eslint": "^8.52.0",
+    "eslint-plugin-jest": "^27.4.3",
     "jest": "^29.7.0",
     "marked": "^9.1.2",
     "open-cli": "^7.2.0",

worker/include/RTC/IceServer.hpp

@@ -93,9 +93,11 @@ namespace RTC
 		}
 		bool IsValidTuple(const RTC::TransportTuple* tuple) const;
 		void RemoveTuple(RTC::TransportTuple* tuple);
-		// This should be just called in 'connected' or completed' state
-		// and the given tuple must be an already valid tuple.
-		void ForceSelectedTuple(const RTC::TransportTuple* tuple);
+		/**
+		 * This should be just called in 'connected' or 'completed' state and the
+		 * given tuple must be an already valid tuple.
+		 */
+		void MayForceSelectedTuple(const RTC::TransportTuple* tuple);
 
 	private:
 		void HandleTuple(
@@ -122,8 +124,8 @@ namespace RTC
 		std::string password;
 		std::string oldUsernameFragment;
 		std::string oldPassword;
-		uint32_t remoteNomination{ 0u };
 		IceState state{ IceState::NEW };
+		uint32_t remoteNomination{ 0u };
 		std::list<RTC::TransportTuple> tuples;
 		RTC::TransportTuple* selectedTuple{ nullptr };
 	};