-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset Streamer #126
Merged
Merged
Asset Streamer #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation of client assets streaming. Client-side scripting implementation is still pending. This feature only takes care of downloading promoted files from the server. TODO: * Implement a simple download dialog in web app to display progress and potential errors * Implement client-side scripting and ensure Lua files are sent pre-compiled and bundled
3 tasks
Unblocks MafiaHub/MafiaMP#117 |
Avoid using the same channel we use for general sync.
* handle re-downloads for hot reloading * provide a download finished/failed callback * stop pending download if server asks us to download assets again or the client demands it (hot reloading purposes)
zpl-zak
added a commit
to MafiaHub/MafiaMP
that referenced
this pull request
Feb 21, 2025
Segfaultd
reviewed
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of client assets streaming.
Client-side scripting implementation is still pending. This feature only takes care of downloading promoted files from the server.
TODO: