Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable French and Portuguese preview #191

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

@Keith-CY Keith-CY requested a review from WhiteMinds June 14, 2023 10:47
@vercel
Copy link

vercel bot commented Jun 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nervos-official-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 10:50am

@matt-nervos
Copy link
Contributor

@Keith-CY are these translations ok?

@WhiteMinds
Copy link
Contributor

Do we need more options here?

image

Or just rely on the automatic switching behavior?

@Keith-CY Keith-CY marked this pull request as draft July 21, 2023 02:56
@Keith-CY
Copy link
Member Author

@Keith-CY are these translations ok?

This PR is for a preview and proofreading of French & Portuguese, so I haven't checked the translation, nor have I added the FR & PT entries in the language list.

The proofreading requires support from the community

Ref: https://discord.com/channels/@me/1074822398941085746/1118493497067065404

@Keith-CY
Copy link
Member Author

Do we need more options here?

image Or just rely on the automatic switching behavior?

We'll extend the language list once the translations are ready, and I've left a question about the style of the language list at https://discord.com/channels/@me/1074822398941085746/1118493497067065404

@Keith-CY Keith-CY force-pushed the develop branch 2 times, most recently from 80ebc3f to f166bd9 Compare July 5, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants