Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miss saving some inputs and outputs #282

Closed
yanguoyu opened this issue Sep 14, 2023 · 5 comments · Fixed by nervosnetwork/neuron#2841
Closed

Miss saving some inputs and outputs #282

yanguoyu opened this issue Sep 14, 2023 · 5 comments · Fixed by nervosnetwork/neuron#2841
Assignees
Labels
bug Something isn't working

Comments

@yanguoyu
Copy link

nervosnetwork/neuron#2672 brings a bug that may miss some inputs and outputs owned to the current wallet.

If the current wallet has derived addresses, and these addresses have some balance. Once I would send all of the balance to the first address. When I sync from a new Neuron, the send-all transaction will sync from the first address but currently the input address may not have been derived. Then the derived address's input will not be saved into the database. After that, when the address has been derived, its input will not be saved because the transaction has synced.
I propose a solution to resolve this problem. The indexer_tx_hash_cache table's transactions are synced to the appointed blake160s. We'd better filter the inputs and outputs by the blake160s.

Another problem is I save lastCachedBlockNumber with wallet ID, it also affects the derived addresses's transactions' synchronization. I should save the lastCachedBlockNumber with wallet ID and blake160s.

But I need more time to resolve these problems, If we need to release recently, I will remove the block number cache for wallet ID, and remove the cell filter when saving inputs and outputs into the database.

@yanguoyu
Copy link
Author

@Keith-CY @Danie0918

@Danie0918
Copy link
Contributor

This needs to be resolved before going live, but the timing of the release and the technical solution needs to be judged down by @Keith-CY

@Keith-CY
Copy link
Member

This needs to be resolved before going live, but the timing of the release and the technical solution needs to be judged down by @Keith-CY

The release date can be postponed until the product is really ready to go. cc @yanguoyu

@yanguoyu
Copy link
Author

This needs to be resolved before going live, but the timing of the release and the technical solution needs to be judged down by @Keith-CY

The release date can be postponed until the product is really ready to go. cc @yanguoyu

OK, I will close nervosnetwork/neuron#2840 and create a PR after I resolve this problem.

@yanguoyu
Copy link
Author

@Danie0918 Danie0918 moved this from 👀 Testing to 🚩Pre Release in Neuron Sep 25, 2023
@Keith-CY Keith-CY moved this from 🚩Pre Release to ✅ Done in Neuron Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants