revert: Remove cache block number and filter cell #2840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanguoyu
force-pushed
the
revert-cell-opt
branch
from
fd8c2e7 to
2f89bce
Compare
yanguoyu
commented
Sep 14, 2023
| @@ -201,7 +201,7 @@ export default class AddressService { | |||
| await getConnection().manager.save(publicKeyInfo) | |||
|
|
|||
| const addressMeta = AddressMeta.fromHdPublicKeyInfoModel(publicKeyInfo.toModel()) | |||
| this.notifyAddressCreated([addressMeta], undefined) | |||
| AddressService.notifyAddressCreated([addressMeta], undefined) | |||
There was a problem hiding this comment.
generateAndSaveForPublicKey is a static function, and a static function calls it. If use this, when I start Neuron the first time without a database file, it throws an error that can not called with undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to Magickbase/neuron-public-issues#282.
If Neuron is released soon, This PR should be merged and I will continue to complete the cell storage optimate into the next version.
If not, This PR should not be merged and I will as soon as possible complete the cell storage optimate and open a PR.