Add example CLI project #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erik-White
commented
Apr 23, 2024
| option(BUILD_EXAMPLES "build examples" OFF) | ||
|
|
||
| if(CMAKE_BUILD_TYPE STREQUAL "") | ||
| set(CMAKE_BUILD_TYPE "Debug") |
There was a problem hiding this comment.
Building from the command line was not working (cmake -S . -B build_linux/) since CMAKE_BUILD_TYPE was not set at that stage. That mean that the ffmpeg packages couldn't be found because the path was incomplete.
Erik-White
commented
Apr 23, 2024
| @@ -31,69 +31,32 @@ | |||
| static bool initialized = false; | |||
| static vx_log_callback log_cb = NULL; | |||
|
|
|||
| struct vx_audio_info | |||
There was a problem hiding this comment.
I had to move these to the header file so they could be used in the new CLI
klerebladh
reviewed
Jun 13, 2024
|
|
||
| for (int i = 0; i < video->frame_queue_count; i++) { | ||
| av_frame_unref(video->frame_queue[i]); | ||
| av_frame_free(&video->frame_queue[i]); | ||
| } | ||
|
|
||
| if (video->hw_device_ctx) |
| #define VX_DECLSPEC __attribute__((visibility("default"))) | ||
| #define VX_CDECL __attribute__((__cdecl__)) | ||
| #define VX_CDECL |
There was a problem hiding this comment.
Make sure this change doesn't cause any issues on Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example CLI project.
The CLI can be used to run Valgrind and the readme has been updated with instructions.