Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech/3483/integrate kotter #3609

Open
wants to merge 112 commits into
base: main
Choose a base branch
from
Open

Tech/3483/integrate kotter #3609

wants to merge 112 commits into from

Conversation

Nereboss
Copy link
Contributor

@Nereboss Nereboss commented May 6, 2024 •
edited by BenediktMehl
Loading

Rebuild functionality of the no longer supported KotlinInquirer using Kotter

Issue: #3483

Description

Use the Kotter library to rebuild the functionality of the KolinInquirer Library. It is currently used for the interactive CLI interface but is no longer supported.
Using our own questions built with kotter gives us more control over the interactive questions and allows for features like auto completion.
This also integrates the new kotter methods into the StructureModifier.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated
    • Not sure if required here?

Screenshots or gifs

@phanlezz phanlezz force-pushed the tech/3483/integrate-kotter branch from 6282905 to 11807b5 Compare May 6, 2024 13:23
@phanlezz
Copy link
Collaborator

phanlezz commented May 6, 2024

I rebased the changes on-top of the current main branch.

@Nereboss Nereboss mentioned this pull request May 7, 2024
Closed
14 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Nereboss
Copy link
Contributor Author

This is blocked by flaky tests that we think are caused by a bug in kotters testing library (we created an issue for that: varabyte/kotter#114)

@phanlezz phanlezz force-pushed the tech/3483/integrate-kotter branch from efb4e7e to 5abd1e1 Compare December 17, 2024 09:17
@phanlezz phanlezz linked an issue Feb 10, 2025 that may be closed by this pull request
Replace KotlinInquirer #3483
Open
9 tasks
@phanlezz phanlezz force-pushed the tech/3483/integrate-kotter branch from 596e174 to 9e94064 Compare February 11, 2025 12:24
@phanlezz
Copy link
Collaborator

Okay I think this is somewhat ready for review. It is up to @ChristianHuehn and @BenediktMehl to maybe check if the coverage can be increased in the dialogs. If not, we may add an exception or add it as potential new e2e tests to my collection issue #3923 .

@BenediktMehl BenediktMehl force-pushed the tech/3483/integrate-kotter branch 5 times, most recently from 56d3a4f to 7872533 Compare February 19, 2025 12:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@BenediktMehl BenediktMehl force-pushed the tech/3483/integrate-kotter branch from c4666f5 to 0cd12d3 Compare February 28, 2025 10:43
Nereboss and others added 14 commits February 28, 2025 11:44
@Nereboss @BenediktMehl
Built first function with kotter
c8b7548
@phanlezz @BenediktMehl
Fix import format and unused imports
90adf1f
@Nereboss @BenediktMehl
Refactor Inquirer into own module #3483
8f61cea
@Nereboss @BenediktMehl
Add inputNumber function #3483
26d3df1
@Nereboss @BenediktMehl
Add promptConfirm function #3483
fdab626
@Nereboss @BenediktMehl
Add promptList function #3483
4535f06
@Nereboss @BenediktMehl
Add promptCheckbox function #3483
ad217fa
@Nereboss @BenediktMehl
Refactor inquirer functions #3483
f799e6d 
Class is no longer needed as all functions extend the Session class from Kotter and are applicable in the correct scope
@Nereboss @BenediktMehl
Test Inquirer on StructureModifier; WIP Commit #3483
ab52d27 
Still a lot of todos that need to be closed and comments that need to be implemented, as well as finding a solution for the session problem
@Nereboss @BenediktMehl
Update Kotter version #3483
68ed7b4
@Nereboss @BenediktMehl
Add text for invalid input in checkbox-function #3483
00cc229
@Nereboss @BenediktMehl
Changed PromptConfirm to color-code the selection #3483
fe8ea66
@Nereboss @BenediktMehl
Improve error handling for promptInput #3483
bf2d1e4
@Nereboss @BenediktMehl
Add test file for Inquirer #3483
699bf39
@BenediktMehl
test: fix tab with #3483
9508f5a
@BenediktMehl
style: callbacks #3483
4e38291
@BenediktMehl
refactor(analysis): add session to collectParserArgs #3483
9c6d1e3
@BenediktMehl
refactor(analysis): adjust tests #3483
38d276e
@BenediktMehl
fix(analysis): session starting in tests #3483
a00c8e9
@BenediktMehl
fix(analysis): session starting in execute parser tests #3483
b4de011
@BenediktMehl
test(analysis): fix ParserService tests #3483
7917755
@BenediktMehl
test(analysis): mock callback for InteractiveDialog #3483
85a7e2d
@BenediktMehl
test(analysis): mock startSession for ParserService #3483
e47e216
@BenediktMehl
test(analysis): mock startSession #3483
229e8f8
@BenediktMehl
test(analysis): increase tokei test cov #3483
f336fcb
@BenediktMehl
test(analysis): increase tokei test cov again #3483
e6f5795
@BenediktMehl
test(analysis): increase csv test cov #3483
7910058
@BenediktMehl
feat(analysis): add output hint to codemaat #3483
2c5c7c3
@BenediktMehl
test(analysis): fix tokei input not provided #3483
88aa3b7
@BenediktMehl
test(analysis): increase codemaat cov #3483
d4e3b1d
@BenediktMehl
test(analysis): increase rawtext cov #3483
e2674b1
@BenediktMehl
fix(analysis): rawtext question #3483
2df473a
@BenediktMehl
test(analysis): improve line cov #3483
921f604
@BenediktMehl
test(analysis): improve gitlogparser cov #3483
b10cc1f
@BenediktMehl
test(analysis): improve sonar importer cov #3483
3144008
@BenediktMehl
test(analysis): improve merge filter cov #3483
2df8c40
@BenediktMehl
refactor(analysis): move mockStartSession to own class #3483
3e02298
@BenediktMehl
refactor(analysis): rename startSession #3483
9592bbd
@BenediktMehl
docs(analysis): update CHANGELOG.md #3483
fd489b3
@BenediktMehl
refactor(analysis): reduce Inquirer complexity #3483
576585d
@BenediktMehl
refactor(analysis): refactor and move mockStartSession #3483
bc2ee26
@BenediktMehl BenediktMehl force-pushed the tech/3483/integrate-kotter branch from 0cd12d3 to bc2ee26 Compare February 28, 2025 10:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace KotlinInquirer
3 participants
@Nereboss @phanlezz @BenediktMehl