Bug/3876/reset camera #3896
Merged
Bug/3876/reset camera #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenediktMehl
force-pushed
the
bug/3876/reset-camera
branch
from
3d17347 to
e2c768c
Compare
IhsenBouallegue
approved these changes
Jan 31, 2025
If deep copy is used the store thinks all objects and arrays are changed even though they were just copied
BenediktMehl
force-pushed
the
bug/3876/reset-camera
branch
from
df3402a to
c1fead3
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix auto fitting camera
Closes: #3876
Description
The camera should only be reseted (auto fitted) if there is a change to the area of the map (or the height scaling)
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled:
Screenshots or gifs