Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/3899/upload same map twice #3901

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Conversation

BenediktMehl
Copy link
Collaborator

@BenediktMehl BenediktMehl commented Jan 29, 2025

App freeze when uploading a file that is already loaded

Closes: #3899

Description

When uploading, if all files are already uploaded, the application remains stuck in the loading animation. The visibleFiles does not change if only already uploaded files are uploaded again (This behavior was introduced in #3788). This was intentional, but it had the side effect that the RgNx store did not trigger the effects that would normally follow a file upload. One of these effects was responsible for removing the loading animation.

I fixed the issue by checking if a file upload added any new files. If no new files were added, there is an error that is caught by the file upload process, which then stops the loading animation.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment but otherwise it works and love that we have tests for it now 🥇

@BenediktMehl BenediktMehl force-pushed the bug/3899/upload-same-map-twice branch from 3c5f4e1 to 288118d Compare January 31, 2025 14:01
@BenediktMehl BenediktMehl enabled auto-merge (rebase) January 31, 2025 14:07
Copy link

Copy link

@BenediktMehl BenediktMehl merged commit fb16860 into main Jan 31, 2025
8 checks passed
@BenediktMehl BenediktMehl deleted the bug/3899/upload-same-map-twice branch January 31, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading the same map twice results in an endless loop
2 participants