Skip to content

Commit

Permalink
Merge pull request #42 from pauldn-wttj/add-extra-env
Browse files Browse the repository at this point in the history
Add extraEnv to values
  • Loading branch information
MaikuMori authored Aug 5, 2024
2 parents bbe7c54 + 649da8e commit 13506fc
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 5 deletions.
5 changes: 5 additions & 0 deletions charts/gotenberg/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 1.6.0

- Bump `gotenberg` version `8.8.1` -> `8.9.0`.
- Add support for `extraEnv` annotations to provide extra environment variables to `gotenberg` container.

## 1.5.1

- Bump `gotenberg` version `8.7.0` -> `8.8.1`.
Expand Down
4 changes: 2 additions & 2 deletions charts/gotenberg/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "1.5.1"
version: "1.6.0"

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "8.8.1"
appVersion: "8.9.0"

keywords:
- gotenberg
Expand Down
3 changes: 2 additions & 1 deletion charts/gotenberg/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Gotenberg

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/gotenberg)](https://artifacthub.io/packages/helm/maikumori/gotenberg)
![Version: 1.5.1](https://img.shields.io/badge/Version-1.5.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 8.8.1](https://img.shields.io/badge/AppVersion-8.8.1-informational?style=flat-square)
![Version: 1.6.0](https://img.shields.io/badge/Version-1.6.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 8.9.0](https://img.shields.io/badge/AppVersion-8.9.0-informational?style=flat-square)

This is a HELM chart for Gotenberg.

Expand Down Expand Up @@ -79,6 +79,7 @@ helm upgrade my-release maikumori/gotenberg --install
| chromium.proxyServer | string | `""` | Set the outbound proxy server; this switch only affects HTTP and HTTPS requests |
| chromium.restartAfter | string | `""` | Number of conversions after which Chromium will automatically restart. Set to 0 to disable this feature |
| chromium.startTimeout | string | `""` | Maximum duration to wait for Chromium to start or restart |
| extraEnv | list | `[]` | List of extra environment variables for gotenberg container |
| fullnameOverride | string | `""` | |
| gotenberg.gracefulShutdownDurationSec | int | `30` | Set the graceful shutdown duration (default 30s) |
| image.pullPolicy | string | `"IfNotPresent"` | |
Expand Down
7 changes: 5 additions & 2 deletions charts/gotenberg/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
{{- toYaml .Values.podSecurityContext | nindent 8 }}
containers:
- name: {{ .Chart.Name }}
securityContext:
securityContext:
{{- include "gotenberg.securityContext" . | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
Expand Down Expand Up @@ -88,7 +88,7 @@ spec:
- --chromium-deny-list={{ .Values.chromium.denyList }}
{{- end }}
{{- if .Values.chromium.ignoreCertificateErrors }}
- --chromium-ignore-certificate-errors
- --chromium-ignore-certificate-errors
{{- end }}
{{- if .Values.chromium.disableWebSecurity }}
- --chromium-disable-web-security
Expand Down Expand Up @@ -202,6 +202,9 @@ spec:
- name: GOTENBERG_API_BASIC_AUTH_PASSWORD
value: {{ .Values.api.basicAuthPassword }}
{{- end }}
{{- with .Values.extraEnv }}
{{- toYaml . | nindent 10 }}
{{- end }}
ports:
- name: http
containerPort: {{ .Values.api.port }}
Expand Down
5 changes: 5 additions & 0 deletions charts/gotenberg/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ volumeMounts: []
# - name: tmp-volume
# mountPath: /tmp

# -- List of extra environment variables for gotenberg container
extraEnv: []
# - name: FOO
# value: bar

ingress:
# -- Set to true to enable ingress record generation. WARNING: Gotenberg shouldn't be exposed to the internet.
enabled: false
Expand Down

0 comments on commit 13506fc

Please sign in to comment.