Skip to content

Commit

Permalink
Merge pull request #19 from pschumacher/tmp-volume
Browse files Browse the repository at this point in the history
Add volume/volumeMounts support
  • Loading branch information
MaikuMori authored Oct 9, 2023
2 parents 8631ec0 + 34530b9 commit b247926
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 2 deletions.
4 changes: 4 additions & 0 deletions charts/gotenberg/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 0.6.0

- Add `volumes` and `volumeMounts`. (Thanks to [@pschumacher](https://github.com/pschumacher))

## 0.5.1

- Bump `gotenberg` version `7.9.1` -> `7.9.2`.
Expand Down
2 changes: 1 addition & 1 deletion charts/gotenberg/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "0.5.1"
version: "0.6.0"

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
4 changes: 3 additions & 1 deletion charts/gotenberg/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Gotenberg

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/gotenberg)](https://artifacthub.io/packages/search?repo=gotenberg)
![Version: 0.5.1](https://img.shields.io/badge/Version-0.5.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 7.9.2](https://img.shields.io/badge/AppVersion-7.9.2-informational?style=flat-square)
![Version: 0.6.0](https://img.shields.io/badge/Version-0.6.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 7.9.2](https://img.shields.io/badge/AppVersion-7.9.2-informational?style=flat-square)

This is a HELM chart for Gotenberg.

Expand Down Expand Up @@ -108,6 +108,8 @@ helm upgrade my-release maikumori/gotenberg --install
| serviceAccount.create | bool | `false` | Specifies whether a service account should be created |
| serviceAccount.name | string | `""` | The name of the service account to use. # If not set and create is true, a name is generated using the fullname template |
| tolerations | list | `[]` | |
| volumeMounts | list | `[]` | |
| volumes | list | `[]` | |
| webhook.allowList | string | `""` | Set the allowed URLs for the webhook feature using a regular expression |
| webhook.clientTimeout | string | `""` | Set the time limit for requests to the webhook (default 30s) |
| webhook.denyList | string | `""` | Set the denied URLs for the webhook feature using a regular expression |
Expand Down
6 changes: 6 additions & 0 deletions charts/gotenberg/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,8 @@ spec:
port: http
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumeMounts:
{{- toYaml .Values.volumeMounts | nindent 12 }}
terminationGracePeriodSeconds: {{ .Values.gotenberg.gracefulShutdownDurationSec }}
{{- with .Values.nodeSelector }}
nodeSelector:
Expand All @@ -187,3 +189,7 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.volumes }}
volumes:
{{- toYaml . | nindent 8 }}
{{- end }}
10 changes: 10 additions & 0 deletions charts/gotenberg/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,16 @@ tolerations: []

affinity: {}

volumes: []
# - name: tmp-volume
# emptyDir:
# medium: Memory
# sizeLimit: 2Gi

volumeMounts: []
# - name: tmp-volume
# mountPath: /tmp

ingress:
# -- Set to true to enable ingress record generation. WARNING: Gotenberg shouldn't be exposed to the internet.
enabled: false
Expand Down

0 comments on commit b247926

Please sign in to comment.