Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm schema and supporting actions (version 1.8.0) #48

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

MaikuMori
Copy link
Owner

@MaikuMori MaikuMori commented Oct 14, 2024

Helm tooling is all over the place. I'm adding experimental schema generation via helm-tool. In theory, we could also replace helm-docs with helm-tool, but that would require rewriting the comments. I'm not opposed to this, but let's get the schema working first.

There is also https://github.com/losisin/helm-values-schema-json which has some cool features like custom validation from comments, but I dislike the inline comment style and having to duplicate the description if we want to have both helm-docs and their schema generation.

The current implementation using helm-tool has the downside of descriptions in the schema being prefixed with helm-docs -- prefix.

Other than that, I'm looking forward to helm-tool updates, and maybe we can switch to using just that for everything.

I'm going to keep this open for a bit for potential feedback or additional changes that could be pushed in the 1.8.0 release.

Tasks:

  • I've made changes
  • I've bumped chart's version in Chart.yaml
  • I've added changes to charts CHANGELOG.md
  • I've run helm-docs

@MaikuMori MaikuMori changed the title Add helm schema and supporting actions Add helm schema and supporting actions (version 1.8.0) Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant