Add helm schema and supporting actions (version 1.8.0) #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm tooling is all over the place. I'm adding experimental schema generation via helm-tool. In theory, we could also replace
helm-docs
withhelm-tool
, but that would require rewriting the comments. I'm not opposed to this, but let's get the schema working first.There is also https://github.com/losisin/helm-values-schema-json which has some cool features like custom validation from comments, but I dislike the inline comment style and having to duplicate the description if we want to have both helm-docs and their schema generation.
The current implementation using
helm-tool
has the downside of descriptions in the schema being prefixed withhelm-docs
--
prefix.Other than that, I'm looking forward to
helm-tool
updates, and maybe we can switch to using just that for everything.I'm going to keep this open for a bit for potential feedback or additional changes that could be pushed in the
1.8.0
release.Tasks:
Chart.yaml
CHANGELOG.md
helm-docs