Skip to content

Commit

Permalink
Remove koishi simulator tests
Browse files Browse the repository at this point in the history
They proved to be very fragile and of limited use in finding actual
issues.
  • Loading branch information
DanNixon committed Jul 31, 2024
1 parent cadc765 commit 57adc4e
Show file tree
Hide file tree
Showing 20 changed files with 1 addition and 920 deletions.
21 changes: 0 additions & 21 deletions .github/workflows/koishi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,6 @@ jobs:
- name: Clippy
run: nix develop --command cargo clippy -- -Dwarnings

formatting-firmware-tests:
name: Formatting (firmware tests)
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./koishi/firmware-tests

steps:
- uses: actions/checkout@v4
- uses: cachix/install-nix-action@V27

- name: Clippy
run: nix develop --command cargo clippy -- -Dwarnings

build-and-test-firmware:
name: Build and Test (firmware)
runs-on: ubuntu-latest
Expand All @@ -53,12 +39,5 @@ jobs:
- name: Build
working-directory: ./koishi/firmware
run: |
# Build as intended for hardware first
nix develop --command cargo build --release
nix develop --command cargo build --release --features telemetry
# Build for simulator tests
nix develop --command cargo build --release --features simulator
- name: In Simulator Tests
working-directory: ./koishi/firmware-tests
run: nix develop --command cargo test
5 changes: 0 additions & 5 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@
ravedude
pkgsCross.avr.buildPackages.gcc

# koishi firmware in-simulator tests
clang
libelf
zlib

# satori firmware
flip-link
probe-rs
Expand Down
Loading

0 comments on commit 57adc4e

Please sign in to comment.